-
Notifications
You must be signed in to change notification settings - Fork 569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Add panels for ingest storage to Writes and Queries dashboards #7670
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a8bc72a
Add some ingest storage dashboards. Not yet finished.
pstibrany 5acdeb7
Added strong consistency and last produced offsets requests and laten…
pstibrany e6407c7
Reworked fetching and processing panels
pstibrany 68ada98
Add panel with WriteSync latency.
pstibrany 36a0580
CHANGELOG.md entry.
pstibrany 7e82c5f
Add read errors to the panel.
pstibrany da9e091
Review
pstibrany 68ebf1f
Added panel with ratio of requests with strong consistency.
pstibrany 13a8097
Fix config.
pstibrany bc5a453
Enhance ratio panel to show both successful and failed requests.
pstibrany 904e1ce
Enhance description of failed reads.
pstibrany 8388d6e
Last round of reviews.
pstibrany File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -167,6 +167,157 @@ local filename = 'mimir-queries.json'; | |||||
{ fieldConfig+: { defaults+: { unit: 'short' } } }, | ||||||
) | ||||||
) | ||||||
.addRowIf( | ||||||
$._config.show_ingest_storage_panels, | ||||||
($.row('Ingester (ingest storage: strong consistency)')) | ||||||
.addPanel( | ||||||
$.timeseriesPanel('Requests with strong consistency') + | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [nit] WDYT about being more specific about the "strong consistency"?
Suggested change
If you agree, same comment applies in other places. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sounds good, fixing. |
||||||
$.panelDescription( | ||||||
'Requests with strong consistency', | ||||||
||| | ||||||
Shows rate of requests with strong consistency, and rate of failed requests with strong consistency. | ||||||
||| | ||||||
) + | ||||||
$.queryPanel( | ||||||
[ | ||||||
||| | ||||||
sum(rate(cortex_ingest_storage_strong_consistency_requests_total{%s}[$__rate_interval])) | ||||||
- | ||||||
sum(rate(cortex_ingest_storage_strong_consistency_failures_total{%s}[$__rate_interval])) | ||||||
||| % [$.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester)], | ||||||
||| | ||||||
sum(rate(cortex_ingest_storage_strong_consistency_failures_total{%s}[$__rate_interval])) | ||||||
||| % [$.jobMatcher($._config.job_names.ingester)], | ||||||
], | ||||||
[ | ||||||
'requests', | ||||||
pstibrany marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
'failed', | ||||||
], | ||||||
) + { | ||||||
fieldConfig+: { | ||||||
defaults+: { unit: 'reqps' }, | ||||||
}, | ||||||
} + $.aliasColors({ failed: $._colors.failed }) + $.stack, | ||||||
) | ||||||
.addPanel( | ||||||
$.timeseriesPanel('Requests with strong consistency ratio') + | ||||||
$.panelDescription( | ||||||
'Requests with strong consistency ratio', | ||||||
||| | ||||||
Ratio between requests with strong consistency and all read requests on ingesters. | ||||||
||| | ||||||
) + | ||||||
$.queryPanel( | ||||||
[ | ||||||
||| | ||||||
( | ||||||
sum(rate(cortex_ingest_storage_strong_consistency_requests_total{%s}[$__rate_interval])) | ||||||
- | ||||||
sum(rate(cortex_ingest_storage_strong_consistency_failures_total{%s}[$__rate_interval])) | ||||||
) | ||||||
/ | ||||||
sum(rate(cortex_request_duration_seconds_count{%s,route=~"%s"}[$__rate_interval])) | ||||||
||| % [$.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester), $._config.ingester_read_path_routes_regex], | ||||||
||| | ||||||
sum(rate(cortex_ingest_storage_strong_consistency_failures_total{%s}[$__rate_interval])) | ||||||
/ | ||||||
sum(rate(cortex_request_duration_seconds_count{%s,route=~"%s"}[$__rate_interval])) | ||||||
||| % [$.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester), $._config.ingester_read_path_routes_regex], | ||||||
], | ||||||
['successful', 'failed'], | ||||||
) | ||||||
+ $.aliasColors({ failed: $._colors.failed, successful: $._colors.success }) | ||||||
+ { fieldConfig+: { defaults+: { unit: 'percentunit', min: 0, max: 1 } } } | ||||||
+ $.stack | ||||||
) | ||||||
.addPanel( | ||||||
$.timeseriesPanel('Strong consistency queries — wait latency') + | ||||||
$.panelDescription( | ||||||
'Strong consistency queries — wait latency', | ||||||
||| | ||||||
How long does the request wait to guarantee strong consistency. | ||||||
||| | ||||||
) + | ||||||
$.queryPanel( | ||||||
[ | ||||||
'max(max_over_time(cortex_ingest_storage_strong_consistency_wait_duration_seconds{%s,quantile="0.5"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
'max(max_over_time(cortex_ingest_storage_strong_consistency_wait_duration_seconds{%s,quantile="0.99"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
'max(max_over_time(cortex_ingest_storage_strong_consistency_wait_duration_seconds{%s,quantile="0.999"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
'max(max_over_time(cortex_ingest_storage_strong_consistency_wait_duration_seconds{%s,quantile="1.0"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
], | ||||||
[ | ||||||
'50th percentile', | ||||||
'99th percentile', | ||||||
'99.9th percentile', | ||||||
'100th percentile', | ||||||
], | ||||||
) + { | ||||||
fieldConfig+: { | ||||||
defaults+: { unit: 's' }, | ||||||
}, | ||||||
}, | ||||||
) | ||||||
) | ||||||
.addRowIf( | ||||||
$._config.show_ingest_storage_panels, | ||||||
($.row('Ingester (ingest storage: last produced offset)')) | ||||||
.addPanel( | ||||||
$.timeseriesPanel('Last produced offset requests / sec') + | ||||||
$.panelDescription( | ||||||
'Rate of requests to fetch last produced offset for partition', | ||||||
||| | ||||||
Shows rate of requests to fetch last produced offset for partition, and rate of failed requests. | ||||||
||| | ||||||
) + | ||||||
$.queryPanel( | ||||||
[ | ||||||
||| | ||||||
sum(rate(cortex_ingest_storage_reader_last_produced_offset_requests_total{%s}[$__rate_interval])) | ||||||
- | ||||||
sum(rate(cortex_ingest_storage_reader_last_produced_offset_failures_total{%s}[$__rate_interval])) | ||||||
||| % [$.jobMatcher($._config.job_names.ingester), $.jobMatcher($._config.job_names.ingester)], | ||||||
||| | ||||||
sum(rate(cortex_ingest_storage_reader_last_produced_offset_failures_total{%s}[$__rate_interval])) | ||||||
||| % [$.jobMatcher($._config.job_names.ingester)], | ||||||
], | ||||||
[ | ||||||
'requests', | ||||||
pstibrany marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
'failed', | ||||||
], | ||||||
) + { | ||||||
fieldConfig+: { | ||||||
defaults+: { unit: 'reqps' }, | ||||||
}, | ||||||
} + $.aliasColors({ failed: $._colors.failed }) + $.stack, | ||||||
) | ||||||
.addPanel( | ||||||
$.timeseriesPanel('Last produced offset latency') + | ||||||
$.panelDescription( | ||||||
'Latency', | ||||||
||| | ||||||
How long does it take to fetch "last produced offset" of partition. | ||||||
||| | ||||||
) + | ||||||
$.queryPanel( | ||||||
[ | ||||||
'max(max_over_time(cortex_ingest_storage_reader_last_produced_offset_request_duration_seconds{%s,quantile="0.5"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
'max(max_over_time(cortex_ingest_storage_reader_last_produced_offset_request_duration_seconds{%s,quantile="0.99"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
'max(max_over_time(cortex_ingest_storage_reader_last_produced_offset_request_duration_seconds{%s,quantile="0.999"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
'max(max_over_time(cortex_ingest_storage_reader_last_produced_offset_request_duration_seconds{%s,quantile="1.0"}[$__rate_interval]))' % [$.jobMatcher($._config.job_names.ingester)], | ||||||
], | ||||||
[ | ||||||
'50th percentile', | ||||||
'99th percentile', | ||||||
'99.9th percentile', | ||||||
'100th percentile', | ||||||
], | ||||||
) + { | ||||||
fieldConfig+: { | ||||||
defaults+: { unit: 's' }, | ||||||
}, | ||||||
}, | ||||||
) | ||||||
) | ||||||
.addRow( | ||||||
$.row('Querier') | ||||||
.addPanel( | ||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is what we use in the Reads dashboard but I think it's missing several stuff (e.g. ActiveSeries, UserStats, ...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will send separate PR to fix, since it's unrelated to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #7676.