Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixin user id format #7724

Merged
merged 3 commits into from
Mar 27, 2024
Merged

Fix mixin user id format #7724

merged 3 commits into from
Mar 27, 2024

Conversation

aldernero
Copy link
Contributor

What this PR does

Which issue(s) this PR fixes or relates to

This PR fixes 3 issues:

  1. The user/tenant id is sometimes abbreviated as a number in the tables in the Top Tenants dashboard. For example, the id 123456 might get abbreviated as 123K, making it not useful for debugging purposes. The auto formatting of the field seems to depend on what else is in the table and possible Grafana version. This PR makes the field format explicitly a string.
  2. In transformations the value column used to show up as "Value #A", so that's how it's referenced in the same tables as for issue 1. The column is now just "Value". In the tables the alias for the column no longer shows up, since "Value #A" doesn't match. This PR fixes that so the aliases show up in the column header.
  3. Fixes a typo in the Slow Queries dashboard

Checklist

  • [N/A] Tests updated.
  • [N/A] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [N/A] about-versioning.md updated with experimental features.

@aldernero aldernero requested a review from a team as a code owner March 25, 2024 23:36
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this bugfix is worthy a note in CHANGELOG (mixin section).

@aldernero aldernero force-pushed the aldernero/dash-fix-user-abbrev branch from ebf0ffd to 4f2e774 Compare March 27, 2024 15:48
@aldernero aldernero merged commit ea9c352 into main Mar 27, 2024
31 checks passed
@aldernero aldernero deleted the aldernero/dash-fix-user-abbrev branch March 27, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants