Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default read timeout for chunks and index caches #7778

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Change default read timeout for chunks and index caches #7778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@

### Jsonnet

* [CHANGE] Memcached: Change default read timeout for chunks and index caches to `750ms` from `450ms`. #7778
* [BUGFIX] Guard against missing samples in KEDA queries. #7691

### Mimirtool
Expand Down
1 change: 1 addition & 0 deletions operations/helm/charts/mimir-distributed/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ Entries should include a reference to the Pull Request that introduced the chang
* [CHANGE] Remove `-server.grpc.keepalive.max-connection-age` and `-server.grpc.keepalive.max-connection-age-grace` from default config. The configuration now applied directly to distributor, fixing parity with jsonnet. #7269
* [CHANGE] Remove `-server.grpc.keepalive.max-connection-idle` from default config. The configuration now applied directly to distributor, fixing parity with jsonnet. #7298
* [CHANGE] Distributor: termination grace period increased from 60s to 100s.
* [CHANGE] Memcached: Change default read timeout for chunks and index caches to `750ms` from `450ms`. #7778
* [FEATURE] Added experimental feature for deploying [KEDA](https://keda.sh) ScaledObjects as part of the helm chart for the components: distributor, querier, query-frontend and ruler. #7282 #7392 #7431 #7679
* Autoscaling can be enabled via `distributor.kedaAutoscaling`, `ruler.kedaAutoscaling`, `query_frontend.kedaAutoscaling`, and `querier.kedaAutoscaling`.
* Global configuration of `promtheusAddress`, `pollingInterval` and `customHeaders` can be found in `kedaAutoscaling`section.
Expand Down
4 changes: 2 additions & 2 deletions operations/helm/charts/mimir-distributed/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ mimir:
memcached:
addresses: {{ include "mimir.chunksCacheAddress" . }}
max_item_size: {{ mul (index .Values "chunks-cache").maxItemMemory 1024 1024 }}
timeout: 450ms
timeout: 750ms
max_idle_connections: 150
{{- end }}
{{- if index .Values "index-cache" "enabled" }}
Expand All @@ -192,7 +192,7 @@ mimir:
memcached:
addresses: {{ include "mimir.indexCacheAddress" . }}
max_item_size: {{ mul (index .Values "index-cache").maxItemMemory 1024 1024 }}
timeout: 450ms
timeout: 750ms
max_idle_connections: 150
{{- end }}
{{- if index .Values "metadata-cache" "enabled" }}
Expand Down
4 changes: 2 additions & 2 deletions ...elm/tests/enterprise-https-values-generated/mimir-distributed/templates/mimir-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ data:
addresses: dns+enterprise-https-values-mimir-chunks-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 1048576
timeout: 450ms
timeout: 750ms
index_cache:
backend: memcached
memcached:
addresses: dns+enterprise-https-values-mimir-index-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 5242880
timeout: 450ms
timeout: 750ms
metadata_cache:
backend: memcached
memcached:
Expand Down
4 changes: 2 additions & 2 deletions operations/helm/tests/large-values-generated/mimir-distributed/templates/mimir-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ data:
addresses: dns+large-values-mimir-chunks-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 1048576
timeout: 450ms
timeout: 750ms
index_cache:
backend: memcached
memcached:
addresses: dns+large-values-mimir-index-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 5242880
timeout: 450ms
timeout: 750ms
metadata_cache:
backend: memcached
memcached:
Expand Down
4 changes: 2 additions & 2 deletions operations/helm/tests/small-values-generated/mimir-distributed/templates/mimir-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,14 @@ data:
addresses: dns+small-values-mimir-chunks-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 1048576
timeout: 450ms
timeout: 750ms
index_cache:
backend: memcached
memcached:
addresses: dns+small-values-mimir-index-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 5242880
timeout: 450ms
timeout: 750ms
metadata_cache:
backend: memcached
memcached:
Expand Down
4 changes: 2 additions & 2 deletions .../test-enterprise-configmap-values-generated/mimir-distributed/templates/mimir-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,14 @@ data:
addresses: dns+test-enterprise-configmap-values-mimir-chunks-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 1048576
timeout: 450ms
timeout: 750ms
index_cache:
backend: memcached
memcached:
addresses: dns+test-enterprise-configmap-values-mimir-index-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 5242880
timeout: 450ms
timeout: 750ms
metadata_cache:
backend: memcached
memcached:
Expand Down
4 changes: 2 additions & 2 deletions ...lm/tests/test-oss-k8s-1.25-values-generated/mimir-distributed/templates/mimir-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ data:
addresses: dns+test-oss-k8s-1.25-values-mimir-chunks-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 1048576
timeout: 450ms
timeout: 750ms
index_cache:
backend: memcached
memcached:
addresses: dns+test-oss-k8s-1.25-values-mimir-index-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 5242880
timeout: 450ms
timeout: 750ms
metadata_cache:
backend: memcached
memcached:
Expand Down
4 changes: 2 additions & 2 deletions ...ations/helm/tests/test-oss-values-generated/mimir-distributed/templates/mimir-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,14 @@ data:
addresses: dns+test-oss-values-mimir-chunks-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 1048576
timeout: 450ms
timeout: 750ms
index_cache:
backend: memcached
memcached:
addresses: dns+test-oss-values-mimir-index-cache.citestns.svc:11211
max_idle_connections: 150
max_item_size: 5242880
timeout: 450ms
timeout: 750ms
metadata_cache:
backend: memcached
memcached:
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-all-components-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,14 +1460,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-all-components-with-custom-max-skew-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1460,14 +1460,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-all-components-with-tsdb-head-early-compaction-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1462,14 +1462,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-all-components-without-chunk-streaming-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1461,14 +1461,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
12 changes: 6 additions & 6 deletions operations/mimir-tests/test-automated-downscale-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1969,14 +1969,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2112,14 +2112,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down Expand Up @@ -2255,14 +2255,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-autoscaling-custom-target-utilization-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,14 +1812,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-autoscaling-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,14 +1812,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-tests/test-consul-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1830,14 +1830,14 @@ spec:
- -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.chunks-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.index-cache.backend=memcached
- -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency=50
- -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100
- -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=150
- -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880
- -blocks-storage.bucket-store.index-cache.memcached.timeout=450ms
- -blocks-storage.bucket-store.index-cache.memcached.timeout=750ms
- -blocks-storage.bucket-store.metadata-cache.backend=memcached
- -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local.:11211
- -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50
Expand Down
Loading
Loading