Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributor: change reason to too_many_exemplars_per_series_per_request for metrics cortex_discarded_exemplars_total #8010

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

ying-jeanne
Copy link
Contributor

@ying-jeanne ying-jeanne commented Apr 30, 2024

Distributor: change reason to too_many_exemplars_per_series_per_request for metrics cortex_discarded_exemplars_total

What this PR does

the label value of too_many_exemplars_per_series could be confusing, clarify it by mentioning per request

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@ying-jeanne ying-jeanne changed the title Distributor: change reason label value to too_many_exemplars_per_series_per_request Distributor: change reason to too_many_exemplars_per_series_per_request for metrics cortex_discarded_exemplars_total Apr 30, 2024
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ying-jeanne ying-jeanne marked this pull request as ready for review April 30, 2024 15:17
@ying-jeanne ying-jeanne requested a review from a team as a code owner April 30, 2024 15:17
@ying-jeanne ying-jeanne merged commit daefa2f into main Apr 30, 2024
31 checks passed
@ying-jeanne ying-jeanne deleted the fix-label-name branch April 30, 2024 15:17
grafanabot pushed a commit that referenced this pull request Apr 30, 2024
ying-jeanne added a commit that referenced this pull request May 2, 2024
…_request (#8010) (#8015)

(cherry picked from commit daefa2f)

Co-authored-by: Ying WANG <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants