Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonnet: align ingest_storage_partitions_enabled with ingest_storage_enabled #8046

Merged
merged 1 commit into from
May 3, 2024

Conversation

narqo
Copy link
Contributor

@narqo narqo commented May 3, 2024

What this PR does

Following #8028 this PR updates the default value of ingest_storage_partitions_enabled to mirror $._config.ingest_storage_enabled. Such configuration is what we're currently testing internally, as part of the migration of the workloads to the ingest storages.

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@narqo narqo requested a review from a team as a code owner May 3, 2024 13:38
@narqo narqo changed the title mimir: align ingest_storage_partitions_enabled with global ingest_storage_enabled jsonnet: align ingest_storage_partitions_enabled with ingest_storage_enabled May 3, 2024
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pracucci pracucci enabled auto-merge (squash) May 3, 2024 13:44
@pracucci pracucci merged commit 2e1d0c7 into main May 3, 2024
29 checks passed
@pracucci pracucci deleted the mimir-jsonnet-ingest-store-partition-shard-size branch May 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants