Store-gateway: allow postings scans to be interrupted #8154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the filter operation is expensive, e.g. a large regexp, and the posting has a lot of values, filtering can many seconds. Check the context for cancellation every 1024 values. Signed-off-by: Bryan Boreham <[email protected]>
krajorama
reviewed
May 16, 2024
| for d.Err() == nil && !currEntry.isLast { | ||
| if count%checkContextEveryNIterations == 0 && ctx.Err() != nil { | ||
| return nil, ctx.Err() |
There was a problem hiding this comment.
can we wrap the error so we have a bit more details? Also using context.Cause instead of ctx.Err() would give even more details
…ancel Signed-off-by: György Krajcsovits <[email protected]>
56quarters
approved these changes
May 16, 2024
There was a problem hiding this comment.
LGTM with some minor comments. It'd be nice to implement @dimitarvdimitrov 's
suggestions but I understand this is urgent-ish.
Signed-off-by: György Krajcsovits <[email protected]>
francoposa
pushed a commit
that referenced
this pull request
May 27, 2024
* Store-gateway: allow postings scans to be interrupted If the filter operation is expensive, e.g. a large regexp, and the posting has a lot of values, filtering can many seconds. Check the context for cancellation every 1024 values. Signed-off-by: Bryan Boreham <[email protected]> Signed-off-by: György Krajcsovits <[email protected]> Co-authored-by: György Krajcsovits <[email protected]> Co-authored-by: George Krajcsovits <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
If the filter operation is expensive, e.g. a large regexp, and the posting has a lot of values, filtering can many seconds. Check the context for cancellation every 1024 values.
Which issue(s) this PR fixes or relates to
Same issue as grafana/mimir-prometheus#633, but store-gateway does its own index scans.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.