mimir-mixin: update dashboards to not use deprecated "Table (old)" plugin #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
narqo
force-pushed
the
mimir-mixin-g11-dashboards
branch
from
c8614cf to
54a2691
Compare
narqo
commented
May 24, 2024
| @@ -4,7 +4,9 @@ | |||
| set -e | |||
|
|
|||
| SCRIPT_DIR=$(cd `dirname $0` && pwd) | |||
| DOCKER_CONTAINER_NAME="mixin-serve-grafana" | |||
| # Ensure we run recent Grafana. | |||
| GRAFANA_VERSION=11.0.0 | |||
There was a problem hiding this comment.
Note that, as of today, latest tag is Grafana 10.x, which isn't what we want in dev
narqo
added a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
…ugin (grafana#8181) * mimir-mixin: update tablePanel from use of deprecated plugin Signed-off-by: Vladimir Varankin <[email protected]> * rebuild assets Signed-off-by: Vladimir Varankin <[email protected]> * update changelog Signed-off-by: Vladimir Varankin <[email protected]> * mimir-mixin-tools: improve run script to serve with Grafana 11 Signed-off-by: Vladimir Varankin <[email protected]> --------- Signed-off-by: Vladimir Varankin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Grafana 10+ (maybe even earlier) comes with two versions of table plugins: "Table" and "Table (old)". The later one is deprecated, and messes up with the dashboards that use it in Grafana 11.
Note that, similar to #7413, I don't think it's worth it trying to resolve that in grafana-builder at this point. Instead, we should consider completely revisiting how dashboards are built, moving to grafonnet, imho (+1 to grafana/jsonnet-libs#1010).
This PR updates the dashboards, that use a Table panel, to follow the newer plugin's JSON model. Below screenshots are from Grafana 11, showing the updated version of the dashboard:
Mimir / Scaling
Mimir / Top tenants
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.