Mimir query engine: support query cancellation and timeout #8197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
May 28, 2024
jhesketh
approved these changes
May 29, 2024
charleskorn
force-pushed
the
charleskorn/mimir-query-engine-cancellation-and-timeout
branch
from
ab6180d to
a41284a
Compare
Testing for Testing for |
…er evaluation finishes
charleskorn
deleted the
charleskorn/mimir-query-engine-cancellation-and-timeout
branch
narqo
pushed a commit
to narqo/grafana-mimir
that referenced
this pull request
Jun 6, 2024
) * Add support for cancelling queries. * Respect the configured query timeout. * Update changelog entry * Use `storage.ErrSeriesSet` * Ensure we don't leak contexts * Check for context cancellation in `Selector.Next` * Add test case to ensure that query execution context is cancelled after evaluation finishes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds support for cancelling queries (with
Query.Cancel()) and configuring a timeout for queries (withEngineOpts.Timeout) in the Mimir query engine.Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.