Add TestMiddlewaresConsistency #8373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
commented
Jun 14, 2024
| @@ -15,6 +15,12 @@ import ( | |||
| "github.com/prometheus/client_golang/prometheus/promauto" | |||
| ) | |||
|
|
|||
| type instrumentMiddleware struct { | |||
There was a problem hiding this comment.
Note to reviewers: this is a small refactoring to make the instrument middleware detectable via reflection. Before it was an anonymous HandlerFunc.
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
test-query-frontend-middlewares-consistency
branch
from
e6750c0 to
9a3ffcd
Compare
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
In this PR I propose to add
TestMiddlewaresConsistency. This test will help us to ensure that we'll not forget to add a new query-frontend middleware (in the future) to each type of request. If a middleware is specific to a type of request, then the test allows to define exclusions from the check (e.g.splitAndCacheMiddlewareis intentionally only used by range queries).All middlewares are excluded for remote read because we're still working on making it a first class citizen.
Which issue(s) this PR fixes or relates to
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.