Mimir query engine: add HTTP header to force use of Prometheus' engine #8454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/fallback-with-http-header
branch
from
c4e5134 to
2de35d1
Compare
charleskorn
force-pushed
the
charleskorn/fallback-with-http-header
branch
from
2de35d1 to
d5d5fad
Compare
jhesketh
approved these changes
Jun 21, 2024
| @@ -27,6 +27,8 @@ type EngineWithFallback struct { | |||
| logger log.Logger | |||
| } | |||
|
|
|||
| var errFallbackForcedByHTTPHeader = NotSupportedError{"fallback forced by HTTP header"} | |||
There was a problem hiding this comment.
(nit)
I don't know if I like using NotSupportedError here. It's not that the query is necessarily unsupported, but that we aren't going to use the query engine. Maybe we need an error class "MQEError" or something that NotSupportError and Fallback use?
Similarly renaming e.unsupportedQueries to FallbackQueries or similar.
There was a problem hiding this comment.
Good point, I've dropped the awkward use of NotSupportedError in 28c4bc2.
I've kept unsupportedQueries as-is for now - if it annoys us in the future, we can change it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds support for forcing the use of Prometheus' engine when the Mimir query engine is enabled by sending the
X-Mimir-Force-Prometheus-Engine: trueHTTP header with the query request.The header is only effective if fallback to Prometheus' engine is enabled and fallback is enabled (ie.
-querier.enable-promql-engine-fallback=true).Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.