[release-2.13] Fix per-tenant silence limits not reloaded during runtime #8580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix per-tenant silence limits not reloaded during runtime This commit fixes a bug where per-tenant silence limits were not reloaded during runtime. This happened because per-tenant limits were read at initialization time for a per-tenant Alertmanager and then never again. Instead, silence limits are read each time they are needed. Mimir uses an in-memory cache for per-tenant limits, and silence limits are only checked when creating new silences or updating existing silences. * Update go.mod (cherry picked from commit 837a375)
grafanabot
requested review from
stevesg
and removed request for
a team and
stevesg
dimitarvdimitrov
approved these changes
Jul 2, 2024
This was referenced Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 837a375 from #8456