Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE: Add NH support to binary operations #8838

Merged
merged 43 commits into from
Aug 6, 2024
Merged

MQE: Add NH support to binary operations #8838

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
e5c960a
MQE: Complete binary operations
jhesketh Jul 29, 2024
0b3a49c
Merge branch 'main' into jhesketh/mqe-histogram-binary-operations
jhesketh Jul 31, 2024
f1b5ccb
Add note to followup on optimisation
jhesketh Jul 31, 2024
c758b80
Fix moving the index across the slices
jhesketh Jul 31, 2024
e87bfee
Remove comparison operators for now
jhesketh Jul 31, 2024
00d7ea0
Add InstantVectorSeriesDataIterator
jhesketh Jul 31, 2024
d0bcab8
Cleanup computeResult
jhesketh Jul 31, 2024
a55871b
Resolve initial review feedback
jhesketh Jul 31, 2024
04c449d
Merge floats and histograms independantly before checking for conflicts
jhesketh Aug 1, 2024
73f3c4d
rename prepare slice functions
jhesketh Aug 1, 2024
a2aad39
Keep track of indexes when filtering data
jhesketh Aug 1, 2024
385ca19
Remove filteredData struct and sort nil floats/histograms to list end…
jhesketh Aug 1, 2024
0549055
Sort seriesIndices at the same time
jhesketh Aug 1, 2024
d5aa4f2
add note
jhesketh Aug 1, 2024
f3fb019
re-add unsupported operation
jhesketh Aug 1, 2024
07fad3d
Fix time format
jhesketh Aug 1, 2024
d107162
Add tests for histogram series merging
jhesketh Aug 1, 2024
3339d67
Fix lint
jhesketh Aug 2, 2024
655bf3f
Rename some variables for clarity
jhesketh Aug 2, 2024
20ceefe
Return all unused float slices
jhesketh Aug 2, 2024
896a616
Check capacity not length when preparing slices
jhesketh Aug 2, 2024
ab47c83
Move sourceSeriesMetadata out of seriesForOneGroupSide
jhesketh Aug 2, 2024
9f72ae0
Also fix histogram slice returning
jhesketh Aug 2, 2024
f8c3dab
Split out sorters for floats/histograms
jhesketh Aug 2, 2024
05bd5b4
Fix returning the correct slice type
jhesketh Aug 2, 2024
085dc9f
Fix bug with pool usage
jhesketh Aug 5, 2024
d82bdbf
Expand testing to make sure histograms are as expected
jhesketh Aug 5, 2024
e7ea162
Add tests (currently broken)
jhesketh Aug 5, 2024
789317e
Fix re-use of slices with mixed points
jhesketh Aug 6, 2024
d4bd4da
Output first match group with conflicting points
jhesketh Aug 6, 2024
73cc22a
Merge branch 'main' into jhesketh/mqe-histogram-binary-operations
jhesketh Aug 6, 2024
c676185
Update changelog
jhesketh Aug 6, 2024
a4ed465
Fix comment
jhesketh Aug 6, 2024
ea1be7f
Make sure expected histogram is returend in data_test
jhesketh Aug 6, 2024
b19cf6b
Add NH binop benchmark
jhesketh Aug 6, 2024
61c52db
Also benchmark NH + NH
jhesketh Aug 6, 2024
819d5be
Fix+extend comments
jhesketh Aug 6, 2024
e7e4610
Don't export left/right iterator
jhesketh Aug 6, 2024
5558ea7
Use better test naming
jhesketh Aug 6, 2024
390186b
Extend NH binop tests
jhesketh Aug 6, 2024
302f75f
Tweak InstantVectorSeriesData readability
jhesketh Aug 6, 2024
23b3c58
Add extra data test
jhesketh Aug 6, 2024
747dff9
Run merging tests with histograms
jhesketh Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading