Mimir query engine: fix issue where rate() over native histograms could panic or return incorrect results
#8850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/mqe-rate-over-nh
branch
from
9019dd4 to
1c845c3
Compare
aknuds1
reviewed
Jul 30, 2024
| @@ -161,7 +161,6 @@ func (b *FPointRingBuffer) Reset() { | |||
|
|
|||
| // Close releases any resources associated with this buffer. | |||
| func (b *FPointRingBuffer) Close() { | |||
| b.Reset() | |||
There was a problem hiding this comment.
Why is the Reset call unnecessary? Which practical consequences does removing it have?
There was a problem hiding this comment.
Calling Reset is unnecessary because a FPointRingBuffer isn't expected to be used after Close is called.
jhesketh
reviewed
Jul 30, 2024
Co-authored-by: Arve Knudsen <[email protected]>
jhesketh
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes an issue where multiple queries running
rate()over native histograms simultaneously could panic or return incorrect results.This could happen when multiple queries reused the same
FloatHistograminstance due to a bug inHPointRingBuffer.HPointRingBuffercould retain a reference toFloatHistograms while also returning a slice containing thoseFloatHistograms to the pool, so a second query could modify thoseFloatHistograms concurrently with the original query.Note to reviewers: I've tried to build up this PR incrementally. I'd suggest reviewing each commit individually.
Which issue(s) this PR fixes or relates to
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.