Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimir query engine: add support for scalar constants and pi() #8995

Merged
merged 8 commits into from
Aug 16, 2024
Merged

Mimir query engine: add support for scalar constants and pi() #8995

merged 8 commits into from
Aug 16, 2024

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Aug 14, 2024 •
edited
Loading

What this PR does

This PR adds support for scalar constants and the pi() function in MQE.

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review August 14, 2024 07:10
@charleskorn charleskorn requested review from tacole02 and a team as code owners August 14, 2024 07:10
tacole02
tacole02 approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@tacole02 tacole02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@charleskorn charleskorn changed the title Mimir query engine: add support for scalar constants Mimir query engine: add support for scalar constants and pi() Aug 15, 2024
jhesketh
jhesketh reviewed Aug 15, 2024
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a question around handling of pools. These can likely be moved to another discussion or PR given this is in line with what we're currently doing. (But still a question on the matrix).

pkg/streamingpromql/operators/scalar_constant.go Show resolved Hide resolved
pkg/streamingpromql/query.go Show resolved Hide resolved
pkg/streamingpromql/query.go Show resolved Hide resolved
@charleskorn charleskorn force-pushed the charleskorn/mqe-scalars branch from 79ebe8e to f763903 Compare August 16, 2024 00:33
@charleskorn charleskorn force-pushed the charleskorn/mqe-scalars branch from f763903 to eb9cbb0 Compare August 16, 2024 00:54
@charleskorn charleskorn mentioned this pull request Aug 16, 2024
Merged
2 tasks
jhesketh
jhesketh approved these changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :-)

pkg/streamingpromql/query.go Show resolved Hide resolved
pkg/streamingpromql/operators/scalar_constant.go Show resolved Hide resolved
@charleskorn charleskorn merged commit d9b4b94 into main Aug 16, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/mqe-scalars branch August 16, 2024 05:48
@charleskorn charleskorn mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhesketh jhesketh jhesketh approved these changes

@tacole02 tacole02 tacole02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charleskorn @jhesketh @tacole02