copyblocks: add option to bypass duration check for no-compact blocks #9439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CHANGELOG has just been cut to prepare for the next release. Please rebase |
andyasp
force-pushed
the
aasp/any-no-compact-duration
branch
from
afb5414 to
9dd8f6b
Compare
56quarters
approved these changes
Sep 27, 2024
|
I struggled with the name as well. Open to ideas for it and I'll hold off while trying to think of something myself. |
narqo
reviewed
Sep 27, 2024
tools/copyblocks/main.go
Outdated
| @@ -59,6 +60,7 @@ func (c *config) registerFlags(f *flag.FlagSet) { | |||
| f.Var(&c.enabledUsers, "enabled-users", "If not empty, only blocks for these users are copied.") | |||
| f.Var(&c.disabledUsers, "disabled-users", "If not empty, blocks for these users are not copied.") | |||
| f.BoolVar(&c.dryRun, "dry-run", false, "Don't perform any copy; only log what would happen.") | |||
| f.BoolVar(&c.anyNoCompactBlockDuration, "any-no-compact-block-duration", false, "If set, blocks marked as no-compact are not checked against min-block-duration") | |||
There was a problem hiding this comment.
How about --skip-no-compact-block-duration-check?
There was a problem hiding this comment.
That is way more clear. I'll change it to that, thanks!
andyasp
commented
Sep 27, 2024
andyasp
commented
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds a flag to bypass the block duration check in
copyblocksfor blocks marked as no-compact.It's a common pattern to use
min-block-durationwith the intent of targeting blocks that are fully compacted. This can miss blocks that are marked asno-compactthat have a shorter duration. This flag makes it easier to not miss those blocks.Which issue(s) this PR fixes or relates to
Fixes N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.