Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MQE: Add support for label_replace #9532

Merged
merged 12 commits into from
Oct 7, 2024
Merged

MQE: Add support for label_replace #9532

merged 12 commits into from
Oct 7, 2024

Conversation

jhesketh
Copy link
Contributor

@jhesketh jhesketh commented Oct 7, 2024 •
edited
Loading

What this PR does

Which issue(s) this PR fixes or relates to

Fixes #

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@jhesketh jhesketh requested a review from a team as a code owner October 7, 2024 01:27
charleskorn
charleskorn reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this.

I'd be curious to see the benchmark results for label_replace in comparison to Prometheus' engine.

pkg/streamingpromql/functions.go Outdated Show resolved Hide resolved
pkg/streamingpromql/functions.go Outdated Show resolved Hide resolved
pkg/streamingpromql/functions/label.go Outdated Show resolved Hide resolved
pkg/streamingpromql/query.go Show resolved Hide resolved
pkg/streamingpromql/testdata/ours/functions.test Outdated Show resolved Hide resolved
pkg/streamingpromql/testdata/ours/functions.test Show resolved Hide resolved
pkg/streamingpromql/testdata/ours/functions.test Outdated Show resolved Hide resolved
charleskorn
charleskorn reviewed Oct 7, 2024
View reviewed changes
pkg/streamingpromql/engine_test.go Show resolved Hide resolved
pkg/streamingpromql/functions.go Outdated Show resolved Hide resolved
pkg/streamingpromql/query.go Show resolved Hide resolved
pkg/streamingpromql/testdata/ours/functions.test Outdated Show resolved Hide resolved
@jhesketh jhesketh enabled auto-merge (squash) October 7, 2024 06:24
@jhesketh jhesketh merged commit be228aa into grafana:main Oct 7, 2024
29 checks passed
@jhesketh jhesketh deleted the jhesketh/mqe-label_replace branch October 7, 2024 10:34
@jhesketh jhesketh mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleskorn charleskorn charleskorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhesketh @charleskorn