Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE: add support for unary addition #9681

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Oct 20, 2024

What this PR does

This PR adds support for unary addition to MQE.

Unary addition is a no-op, but it's valid PromQL, so we have to support it too 🤷

Which issue(s) this PR fixes or relates to

(none)

Checklist

  • Tests updated.
  • [n/a] Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • [n/a] about-versioning.md updated with experimental features.

@charleskorn charleskorn marked this pull request as ready for review October 20, 2024 23:05
@charleskorn charleskorn requested a review from a team as a code owner October 20, 2024 23:05
Copy link
Contributor

@jhesketh jhesketh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E Z

@charleskorn charleskorn enabled auto-merge (squash) October 21, 2024 03:00
@charleskorn charleskorn force-pushed the charleskorn/mqe-unary-addition branch from 047ca99 to 6c1295d Compare October 21, 2024 03:18
@charleskorn charleskorn merged commit 2c397ed into main Oct 21, 2024
29 checks passed
@charleskorn charleskorn deleted the charleskorn/mqe-unary-addition branch October 21, 2024 03:31
@jhesketh jhesketh mentioned this pull request Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants