Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream rollout-operator zone-tracker settings. #9699

Merged
merged 5 commits into from
Oct 22, 2024

Conversation

seizethedave
Copy link
Contributor

@seizethedave seizethedave commented Oct 21, 2024

What this PR does

Configures rollout-operator to use zone-tracker mode, which uses a configmap to store metadata about statefulset scaling operations rather than as attributes on the statefulset being operated on. We found that the latter caused infinite recursion-type behavior in the K8S clusters of several cloud service providers.

Part of this configuration is granting rollout-operator RBAC permissions to manipulate configmaps.

Which issue(s) this PR fixes or relates to

Checklist

  • Tests updated.
  • Documentation added.
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX].
  • about-versioning.md updated with experimental features.

@seizethedave seizethedave marked this pull request as ready for review October 21, 2024 21:58
@seizethedave seizethedave requested a review from a team as a code owner October 21, 2024 21:58
Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

CHANGELOG.md Outdated Show resolved Hide resolved
@seizethedave seizethedave merged commit 87bf48d into main Oct 22, 2024
29 checks passed
@seizethedave seizethedave deleted the davidgrant/rollout-operator branch October 22, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants