Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Round-Robin Notification Step to Set Importance #1184

Closed
thomasmitchell opened this issue Jan 20, 2023 · 7 comments
Closed

Allow Round-Robin Notification Step to Set Importance #1184

thomasmitchell opened this issue Jan 20, 2023 · 7 comments

Comments

@thomasmitchell
Copy link
Contributor

thomasmitchell commented Jan 20, 2023

Currently, you can set the type of notification sent (default or important) for other step-types such as Notify Users from Schedule or Notify Users, but there is no such option for the Round Robin notification step.

Additionally, it is unclear what kind of notification will currently be sent if a round-robin notification is triggered.

So this is a feature request for Round-Robin step to allow setting the notification importance level.

https://grafana.zendesk.com/agent/tickets/157288

@qmonitoring
Copy link

Indeed, there is no mention in the documentation what kind of notification will be sent (Default or Important) if a round-robin escalation step is chosen.

@ethanmdavidson
Copy link

ethanmdavidson commented Oct 10, 2023

Just did a quick test and it sent the notification at "default" level, which appears to be, ahem, the default. (seems obvious in hindsight!)

To add a usecase here, I'd like to use round-robin as a backstop for the oncall schedule. for example, the escalation chain would be:

  1. notify the scheduled on-call engineer
  2. wait 15 minutes
  3. notify the members of the team 1 by 1, round robin.

The intention here is that if the scheduled on-call engineer doesn't respond for some reason, someone else from the team hopefully will. This usecase would also be helped by #794

@joeyorlando
Copy link
Contributor

@Ferril is there anything blocking this issue?

@Konstantinov-Innokentii
Copy link
Member

@iskhakov @mackgorski it seems your opinion is needed here

@Ferril
Copy link
Member

Ferril commented Oct 31, 2024

@joeyorlando
Copy link
Contributor

@Ferril what's the latest update on this issue?

@mackgorski
Copy link

What @ethanmdavidson mentioned is exactly what customer originally requested apart of marking these notifications as important as I explained several times already. I will make sure to update this issue description. This part was also originally discussed in customer ticket in https://github.com/grafana/support-escalations/issues/11449 I am sure we have this logged as FR as well to implement a proper Round-Robin like solution here. Le me find the FR for the second part of this use case.

github-merge-queue bot pushed a commit that referenced this issue Jan 21, 2025
# What this PR does
Adds `important` version of `Round-robin` escalation step

<img width="1090" alt="Screenshot 2025-01-20 at 11 18 54"
src="https://github.com/user-attachments/assets/add6f9e8-fc6c-40a8-a177-d727cc385651"
/>


## Which issue(s) this PR closes

Related to #1184

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
@Ferril Ferril closed this as completed Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants