Add filtering by team, is_currently_oncall and search on the user page #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskhakov
changed the title
iskhakov
added
release:enhancement
brojd
reviewed
Jun 24, 2024
| }); | ||
| }; | ||
|
|
||
| applyFilters = () => { |
There was a problem hiding this comment.
Seems this method is unused, can we remove it? Not related to your changes but there's another unused method in this component - renderContacts, we could remove it too
brojd
approved these changes
Jun 24, 2024
vstpme
approved these changes
Jun 25, 2024
Comment on lines
+859
to
+860
| if filter_name is not None: | ||
| filter_options = list(filter(lambda f: filter_name in f["name"], filter_options)) |
There was a problem hiding this comment.
does the frontend use this search functionality? if not, I think it might make sense to remove this
There was a problem hiding this comment.
I can't find any usages in the frontend code 🤔 Am I missing something?
joeyorlando
approved these changes
Jun 25, 2024
| @@ -841,6 +842,25 @@ def export_token(self, request, pk) -> Response: | |||
| return Response(status=status.HTTP_204_NO_CONTENT) | |||
| return Response(status=status.HTTP_405_METHOD_NOT_ALLOWED) | |||
|
|
|||
| @action(methods=["get"], detail=False) | |||
There was a problem hiding this comment.
I believe we have openapi docs for the /users routes (code). do we need to add anything here to document this new endpoint?
|
|
iskhakov
force-pushed
the
iskhakov/user-filters
branch
from
6fd599c to
0b8e69c
Compare
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
#4575) # What this PR does This PR adds filtering by team and is_currently_oncall on the user page ## Which issue(s) this PR closes Closes #4353 <!-- *Note*: if you have more than one GitHub issue that this PR closes, be sure to preface each issue link with a [closing keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue). This ensures that the issue(s) are auto-closed once the PR has been merged. --> ## Checklist - [ ] Unit, integration, and e2e (if applicable) tests updated - [ ] Documentation added (or `pr:no public docs` PR label added if not required) - [ ] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds filtering by team and is_currently_oncall on the user page
Which issue(s) this PR closes
Closes #4353
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.