Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Slack channel and user group values not populating on first visit of schedule notification settings #4671

Merged
merged 2 commits into from
Jul 15, 2024

Conversation

brojd
Copy link
Contributor

@brojd brojd commented Jul 15, 2024

What this PR does

Make sure GSelect gets rerendered with updated items., more context here

Which issue(s) this PR closes

#4670

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@brojd brojd added the release:patch PR will be added to "Other Changes" section of release notes label Jul 15, 2024
@brojd brojd requested a review from a team July 15, 2024 06:32
@brojd brojd added the pr:no public docs Added to a PR that does not require public documentation updates label Jul 15, 2024
@brojd brojd temporarily deployed to github-pages July 15, 2024 06:32 — with GitHub Actions Inactive
@brojd brojd temporarily deployed to github-pages July 15, 2024 06:42 — with GitHub Actions Inactive
@brojd brojd added this pull request to the merge queue Jul 15, 2024
Merged via the queue into dev with commit 851ca2e Jul 15, 2024
21 checks passed
@brojd brojd deleted the brojd/fix-slack-channel-user-group-values branch July 15, 2024 07:25
brojd added a commit that referenced this pull request Sep 18, 2024
… of schedule notification settings (#4671)

# What this PR does

Make sure GSelect gets rerendered with updated items., more context
[here](https://raintank-corp.slack.com/archives/C04JCU51NF8/p1720559481963519)

## Which issue(s) this PR closes

#4670

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants