Migrate react-router to v6 #4703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosii
added
pr:no public docs
|
Blocked until scenes migrates to react-router v6 |
teodosii
commented
Jul 24, 2024
teodosii
commented
Jul 24, 2024
| @@ -199,7 +240,7 @@ const config = async (env): Promise<Configuration> => { | |||
|
|
|||
| if (isWSL()) { | |||
| baseConfig.watchOptions = { | |||
| poll: 3000, | |||
| // poll: 3000, | |||
There was a problem hiding this comment.
on WSL this isn't really needed. I use WSL and this breaks reloading actually, doesn't seem to be configurable :(
teodosii
commented
Jul 25, 2024
| router: Router<T>; | ||
| } | ||
|
|
||
| export function withRouter<X, T extends PropsWithRouter<X>>(Component: React.FC<T>): React.FC<Omit<T, 'router'>> { |
There was a problem hiding this comment.
Newest v6 react-router seems to no longer export a HOC for withRouter. Added this in here with all the necessary types
brojd
reviewed
Jul 25, 2024
grafana-plugin/.eslintrc.js
Outdated
| @@ -8,6 +8,10 @@ module.exports = { | |||
| 'import/internal-regex': | |||
| '^assets|^components|^containers|^contexts|^icons|^models|^network|^pages|^services|^state|^utils|^plugin', | |||
| }, | |||
| parserOptions: { | |||
There was a problem hiding this comment.
is it needed here since we have it in overrides already? Seems it's a duplication in this case?
There was a problem hiding this comment.
I'd say not as I undo-ed the other packages' updates. But I believe once you bump grafana/eslint, it is needed.
brojd
reviewed
Jul 25, 2024
grafana-plugin/src/pages/escalation-chains/EscalationChains.tsx
Outdated
Show resolved
Hide resolved
brojd
reviewed
Jul 25, 2024
brojd
reviewed
Jul 25, 2024
brojd
approved these changes
Jul 26, 2024
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does - Migrate react-router from v5 to v6 Closes #4031
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Closes #4031