Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to IRM unified plugin #4727

Merged
merged 13 commits into from
Jul 25, 2024
Merged

Adjustments to IRM unified plugin #4727

merged 13 commits into from
Jul 25, 2024

Conversation

brojd
Copy link
Contributor

@brojd brojd commented Jul 24, 2024

What this PR does

  • TypeScript version bump 5.1
  • Other minor tweaks that are required to successfully build and lint IRM plugin with oncall code imported

Which issue(s) this PR closes

Related to https://github.com/grafana/irm/issues/3

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@brojd brojd temporarily deployed to github-pages July 24, 2024 12:42 — with GitHub Actions Inactive
@brojd brojd added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Jul 24, 2024
@brojd brojd temporarily deployed to github-pages July 24, 2024 15:12 — with GitHub Actions Inactive
@brojd brojd changed the title Brojd/irm adjustments Adjustments to IRM unified plugin Jul 25, 2024
@brojd brojd marked this pull request as ready for review July 25, 2024 04:53
@brojd brojd requested a review from a team July 25, 2024 04:53
@brojd brojd temporarily deployed to github-pages July 25, 2024 04:54 — with GitHub Actions Inactive
@brojd brojd temporarily deployed to github-pages July 25, 2024 06:36 — with GitHub Actions Inactive
@brojd brojd temporarily deployed to github-pages July 25, 2024 06:56 — with GitHub Actions Inactive
@brojd brojd added this pull request to the merge queue Jul 25, 2024
Merged via the queue into dev with commit d30d69b Jul 25, 2024
21 checks passed
@brojd brojd deleted the brojd/irm-adjustments branch July 25, 2024 12:28
brojd added a commit that referenced this pull request Sep 18, 2024
# What this PR does

- TypeScript version bump 5.1
- Other minor tweaks that are required to successfully build and lint
IRM plugin with oncall code imported

## Which issue(s) this PR closes

Related to grafana/irm#3

<!--
*Note*: If you want the issue to be auto-closed once the PR is merged,
change "Related to" to "Closes" in the line above.
If you have more than one GitHub issue that this PR closes, be sure to
preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants