Feature: Use ui extension hooks where available #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
leventebalogh
force-pushed
the
leventebalogh/use-extension-hooks
branch
from
ff266fc to
f4e5c58
Compare
leventebalogh
had a problem deploying
to
github-pages
GitHub Actions
Failure
leventebalogh
temporarily deployed
to
github-pages
GitHub Actions
Inactive
leventebalogh
changed the title
leventebalogh
force-pushed
the
leventebalogh/use-extension-hooks
branch
from
bc619de to
96af3dc
Compare
leventebalogh
temporarily deployed
to
github-pages
GitHub Actions
Inactive
leventebalogh
added
pr:no public docs
|
It looks good in general but I want to test it properly just after hackathon + we need to disable deprecation/deprecation eslint rule for now (we've already created a dedicated task to replace deprecated components and then we will enable the eslint rule back). Does it sound ok |
brojd
approved these changes
Aug 13, 2024
brojd
added a commit
that referenced
this pull request
Sep 18, 2024
**What this PR does / why we need it:** This PR updates usage of plugin extensions APIs to take advantage of the new hooks API where available. In older versions we fallback to the currently used hook. This prevents an issue where due to the reactive registry the older APIs don't receive the full list of extensions. It also paves the way for frontend performance improvements in Grafana core. **Which issue(s) this PR fixes:** Related: grafana/grafana-community-team#174 **Special notes for your reviewer:** We would really appreciate some assistance in testing this PR in both the latest version of Grafana 11 and the minimum supported Grafana version. --------- Co-authored-by: Dominik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates usage of plugin extensions APIs to take advantage of the new hooks API where available. In older versions we fallback to the currently used hook. This prevents an issue where due to the reactive registry the older APIs don't receive the full list of extensions. It also paves the way for frontend performance improvements in Grafana core.
Which issue(s) this PR fixes:
Related: https://github.com/grafana/grafana-community-team/issues/174
Special notes for your reviewer:
We would really appreciate some assistance in testing this PR in both the latest version of Grafana 11 and the minimum supported Grafana version.