Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Slack user group for a schedule - handle paid_team_only Slack API error #4793

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

joeyorlando
Copy link
Contributor

What this PR does

Semi-related to https://github.com/grafana/oncall-private/issues/2131

Addresses occasional task failures for apps.slack.tasks.update_slack_user_group_for_schedules when trying to update a Slack user group for a non-paid Slack account. Slack's documentation mentions this is a paid only feature, hence the error (logs from an actual task):

2024-08-08 16:20:36,613 source=engine:celery worker=ForkPoolWorker-16 task_id=6bdaae94-1552-4b6d-93e2-e2fa0bae57b1 task_name=apps.slack.tasks.update_slack_user_group_for_schedules name=apps.slack.models.slack_usergroup level=WARNING Slack usergroup S06LW5GJ88Z update failed: Slack API error! Response: {'ok': False, 'error': 'paid_teams_only'}

Updated our docs on our Slack integration to emphasize that this feature only works for paid Slack accounts

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • Added the relevant release notes label (see labels prefixed w/ release:). These labels dictate how your PR will
    show up in the autogenerated release notes.

@joeyorlando joeyorlando requested a review from a team as a code owner August 8, 2024 21:49
@joeyorlando joeyorlando requested review from a team August 8, 2024 21:49
@joeyorlando joeyorlando self-assigned this Aug 8, 2024
@joeyorlando joeyorlando added the bug Something isn't working label Aug 8, 2024
@joeyorlando joeyorlando added the release:patch PR will be added to "Other Changes" section of release notes label Aug 8, 2024
@joeyorlando joeyorlando changed the title handle Slack API error for paid_team_only error Update Slack user group for a schedule - handle paid_team_only Slack API error Aug 8, 2024
@joeyorlando joeyorlando added this pull request to the merge queue Aug 9, 2024
Merged via the queue into dev with commit 93c92a7 Aug 9, 2024
21 checks passed
@joeyorlando joeyorlando deleted the jorlando/fix-slack-task-error branch August 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release:patch PR will be added to "Other Changes" section of release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants