Fix acknowledge reminder task #5179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferril
added
pr:no public docs
matiasb
approved these changes
Oct 15, 2024
| @@ -41,7 +41,6 @@ def get_handlers_map(): | |||
| AlertGroupLogRecord.TYPE_AUTO_UN_ACK: "alert_group_action", | |||
| AlertGroupLogRecord.TYPE_RESOLVED: "alert_group_action", | |||
| AlertGroupLogRecord.TYPE_UN_RESOLVED: "alert_group_action", | |||
| AlertGroupLogRecord.TYPE_ACK_REMINDER_TRIGGERED: "alert_group_action", | |||
There was a problem hiding this comment.
We don't have reminders for telegram, do we? (so was this doing nothing?)
There was a problem hiding this comment.
Correct, it's a slack-specific feature.
After receiving the signal Telegram representative updates messages related to the alert group (main message and log), but in this case it does it for nothing, since alert group status was not changed and we don't show reminder logs in alert group timeline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
alert_group_action_triggered_signalsince it is used only to post reminder message in Slack thread and it's not needed to be processed by other representativesWhich issue(s) this PR closes
Related to https://github.com/grafana/oncall-private/issues/2953
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.