Merge alert group static labels to integration labels #5262
+169
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
changed the title
|
@Ferril Thanks! Frontend changes are going to live in this PR as well, right? |
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
added
the
release:patch
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
Ferril
had a problem deploying
to
github-pages
GitHub Actions
Failure
joeyorlando
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
LGTM 👍 the demo in the frontend PR looks 🔥 (UX seems much simpler)
engine/apps/labels/models.py
Outdated
There was a problem hiding this comment.
nit I would include the ..._db.py second migration file in the engine/apps/labels directory and just add a comment at the top saying that we'll move it to the engine/apps/labels/migrations directory in a future PR/release
|
It seems that the Grafana Oncall OSS version still cannot use the label feature, is that correct? |
|
@mrbaowei correct, this is a Grafana Cloud only feature |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR should be merged together with frontend changes.
Which issue(s) this PR closes
Related to https://github.com/grafana/oncall-private/issues/2973
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.