fix: address django migration failing on SQLite #5308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
added
pr:no public docs
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Error
joeyorlando
commented
Nov 28, 2024
Comment on lines
+15
to
+24
| # NOTE: commented out due to some issues this was causing w/ SQLite: | ||
| # https://github.com/grafana/oncall/issues/5306 | ||
| # https://github.com/grafana/oncall/issues/5244#issuecomment-2503999986 | ||
| # | ||
| # linter.IgnoreMigration(), | ||
| # common.migrations.remove_field.RemoveFieldDB( | ||
| # model_name='resolutionnoteslackmessage', | ||
| # name='_slack_channel_id', | ||
| # remove_state_migration=('alerts', '0068_remove_resolutionnoteslackmessage__slack_channel_id_state'), | ||
| # ), |
There was a problem hiding this comment.
honestly I don't think there is any harm in commenting this out. It's really only doing a DROP COLUMN statement.
For whatever reason, this seems to fail (only on SQLite; see #5306 for more details):
oncall_db_migration-1 | django.db.utils.OperationalError: error in index alerts_reso_ts_a9bdf7_idx after drop column: no such column: _slack_channel_id
oncall_db_migration-1 | Applying alerts.0070_remove_resolutionnoteslackmessage__slack_channel_id_db...
joeyorlando
commented
Nov 28, 2024
There was a problem hiding this comment.
Before
😢
After
🙂
matiasb
approved these changes
Nov 28, 2024
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR closes
Fixes #5306 (and related to #5244 (comment)) + add CI check to avoid this from happening in the future
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.