fix: patch slack ID reference issue #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Nov 29, 2024
joeyorlando
commented
Nov 29, 2024
Comment on lines
-23
to
-29
| organization = make_organization() | ||
| slack_team_identity = make_slack_team_identity() | ||
| organization, user, slack_team_identity, _ = make_organization_and_user_with_slack_identities() | ||
| slack_channel = make_slack_channel(slack_team_identity) | ||
| organization.slack_team_identity = slack_team_identity | ||
| organization.save() | ||
|
|
||
| user = make_user(organization=organization) |
There was a problem hiding this comment.
make_organization_and_user_with_slack_identities does the same thing as these 6 lines
joeyorlando
commented
Nov 29, 2024
joeyorlando
commented
Nov 29, 2024
| @@ -303,14 +303,14 @@ def post_slack_rate_limit_message(integration_id): | |||
| return | |||
|
|
|||
| default_route = integration.channel_filters.get(is_default=True) | |||
| if (slack_channel_id := default_route.slack_channel_id_or_org_default_id) is not None: | |||
| if (slack_channel := default_route.slack_channel_or_org_default) is not None: | |||
There was a problem hiding this comment.
related to this change
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Nov 30, 2024
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
commented
Nov 30, 2024
There was a problem hiding this comment.
since I've been mucking around a lot lately in engine/apps/slack/scenarios/distribute_alerts.py, I felt an obligation to add full test coverage for IncomingAlertStep.process_signal.. voila
joeyorlando
added
pr:no public docs
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Ferril
reviewed
Dec 2, 2024
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
temporarily deployed
to
github-pages
GitHub Actions
Inactive
joeyorlando
had a problem deploying
to
github-pages
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR closes
Fixes https://github.com/grafana/irm/issues/469
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.