Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update schedule checks notification period and improve wording #5412

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

chore: update schedule checks notification period and improve wording #5412

wants to merge 2 commits into from

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Jan 13, 2025

Related to https://github.com/grafana/oncall-private/issues/2994

  • Extend gaps/empty shift checks to consider 30 days (customizable via param, eventually make it customizable per schedule?); ie. every week (per beat schedule), check the schedule next 30 days
  • Trigger checks via async task on schedule API updates (instead of a sync call)
  • Update notifications wording / link to schedule

@matiasb matiasb added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Jan 13, 2025
@matiasb matiasb force-pushed the matiasb/update-schedule-check-notifications branch from b5d7cf7 to 44d3a1b Compare January 13, 2025 20:22
@matiasb matiasb marked this pull request as ready for review January 13, 2025 20:46
@matiasb matiasb requested a review from a team as a code owner January 13, 2025 20:46
@matiasb matiasb force-pushed the matiasb/update-schedule-check-notifications branch from 44d3a1b to eca3758 Compare January 14, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matiasb