Fix getting label by name #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferril
added
pr:no public docs
Konstantinov-Innokentii
approved these changes
Jan 14, 2025
| @@ -44,7 +45,7 @@ def get_or_create_by_name(cls, organization: "Organization", key_name: str) -> t | |||
| label, _ = LabelsAPIClient(organization.grafana_url, organization.api_token).get_label_by_key_name( | |||
| label_key | |||
| ) | |||
| except LabelsRepoAPIException as e: | |||
| except (LabelsRepoAPIException, JSONDecodeError) as e: | |||
There was a problem hiding this comment.
What exact case it's handling?
There was a problem hiding this comment.
When we get empty response from label repo (not sure why it happens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Handle JSONDecodeError on getting label key by name
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.