Improve test coverage of Upsert #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the test coverage for Upsert to cover a number of edge cases that are possible when creating and updating silences. It also covers some cases which are specific to upserting.
grobinson-grafana
added a commit
to grafana/alerting
that referenced
this pull request
Jun 25, 2024
This commit updates Alertmanager to include grafana/prometheus-alertmanager#89. It is a no-op. It just keeps us up to date.
yuri-tceretian
pushed a commit
to grafana/alerting
that referenced
this pull request
Jun 25, 2024
This commit updates Alertmanager to include grafana/prometheus-alertmanager#89. It is a no-op. It just keeps us up to date.
grobinson-grafana
added a commit
to grafana/alerting
that referenced
this pull request
Jun 26, 2024
This commit updates Alertmanager to include grafana/prometheus-alertmanager#89. It is a no-op. It just keeps us up to date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit improves the test coverage for
Upsertto cover a number of edge cases that are possible when creating and updating silences. It also covers some cases which are specific to upserting.