Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Adaptive Cards in MS Teams integration #90

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

santihernandezc
Copy link

@santihernandezc santihernandezc commented Aug 30, 2024

This PR updates the MS Teams integration to use Adaptive Cards.
The code is mostly taken from https://github.com/grafana/alerting/blob/main/receivers/teams/teams.go

Copy link

@grobinson-grafana grobinson-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm not able to test it on Microsoft Teams, but Santiago has tested it. Should we add some tests?

notify/msteams/msteams.go Outdated Show resolved Hide resolved
@alexander-akhmetov alexander-akhmetov self-assigned this Sep 2, 2024
@alexander-akhmetov alexander-akhmetov force-pushed the santihernandezc/use_adaptive_cards_ms_teams branch 4 times, most recently from d1a070e to fd9b1d1 Compare September 2, 2024 22:47
@alexander-akhmetov alexander-akhmetov force-pushed the santihernandezc/use_adaptive_cards_ms_teams branch from fd9b1d1 to b2665b0 Compare September 2, 2024 22:48
@alexander-akhmetov
Copy link

alexander-akhmetov commented Sep 2, 2024

@grobinson-grafana
Updated and added a few tests, please have a look :)

Copy link

@titolins titolins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

@grobinson-grafana grobinson-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests, look good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants