Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run cypress against an instance with baseURL #675

Merged
merged 4 commits into from
Jan 3, 2022

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented Jan 3, 2022

Runs the exact same cypress tests, but against an instance with PYROSCOPE_BASE_URL set

One of the tests will fail until #674 is merged

@eh-am eh-am force-pushed the ci/cypress-base-url branch from 327ae1c to e109bf7 Compare January 3, 2022 20:00
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 274.24 KB (0%) 5.5 s (0%) 589 ms (-0.12% 🔽) 6.1 s

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #675 (2ced97c) into main (389019b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   75.70%   75.70%           
=======================================
  Files          45       45           
  Lines        1592     1592           
  Branches      294      294           
=======================================
  Hits         1205     1205           
  Misses        358      358           
  Partials       29       29           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 389019b...2ced97c. Read the comment docs.

@eh-am eh-am force-pushed the ci/cypress-base-url branch from 4739eb7 to 2ced97c Compare January 3, 2022 21:40
@petethepig
Copy link
Member

Thanks @eh-am, this is going to be very useful!

@petethepig petethepig merged commit 5d9d6cb into main Jan 3, 2022
@petethepig petethepig deleted the ci/cypress-base-url branch January 3, 2022 22:16
kolesnikovae pushed a commit that referenced this pull request Jan 7, 2022
* ci: run cypress against an instance with baseURL

* use container with docker-compose

* specify basepath in cypress testst push origin
korniltsev pushed a commit that referenced this pull request Jul 18, 2023
Currently the health check under `/ready` will only show the count of
services in a particular state, this will make sure we will display the
state and the services names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants