Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Event data link in ID field #286

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Fix Event data link in ID field #286

merged 1 commit into from
Aug 2, 2024

Conversation

Pexers
Copy link
Contributor

@Pexers Pexers commented Jul 6, 2024

Fix Event data link in ID field

  • The Events query type visualization table has an incorrect data link within the ID field.
  • This fix takes into consideration the user provided baseURL, replacing sentry.io.

@Pexers Pexers requested a review from a team as a code owner July 6, 2024 12:56
@Pexers Pexers requested review from asimpson, bossinc, aangelisc and adamyeats and removed request for a team July 6, 2024 12:56
@CLAassistant
Copy link

CLAassistant commented Jul 6, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Pexers
Copy link
Contributor Author

Pexers commented Jul 22, 2024

@adamyeats Would you be so kind to review this small PR? :)

asimpson
asimpson approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@asimpson asimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

@asimpson
Copy link
Contributor

asimpson commented Aug 2, 2024

@Pexers could you please fix the conflict and then I can merge? 🙏 Sorry for the delay on this!

@asimpson asimpson enabled auto-merge (squash) August 2, 2024 19:40
@asimpson asimpson merged commit 3514b9a into grafana:main Aug 2, 2024
6 of 7 checks passed
@Pexers
Copy link
Contributor Author

Pexers commented Aug 2, 2024

Thanks a lot @asimpson ! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimpson asimpson asimpson approved these changes

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pexers @CLAassistant @asimpson