Allow choosing fields to fetch for sentry events #400
+83
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnvanand
requested review from
bossinc,
aangelisc,
adamyeats and
katebrenner
and removed request for
a team
adamyeats
reviewed
Jan 14, 2025
There was a problem hiding this comment.
@abnvanand Thanks for the contribution! Looks like there's a failing test, could you please investigate?
handlers_test.go:188:
Error Trace: /drone/src/pkg/handlers/handlers_test.go:188
Error: Not equal:
expected: 11
actual : 4
Test: TestSentryDatasource_Events/valid_events_query_should_produce_correct_result
Now that GetEvents returns a map slice instead of a SentryEvent struct slice, the number of fields in Frame will be the same as the JSON response by API server. We also assert that the query string contains our custom fields.
|
@adamyeats I have fixed the failing test. |
adamyeats
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry events API allows choosing which fields to fetch the data for.
sentry-datasourceplugin currently hardcodes a list of fields making them as required fields.This PR pulls those requiredFields into the UI component. A new component named "Fields" is prepopulated with those fields by default and allows users to remove those or add any custom field names.