Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Timeseries #103

Closed
wants to merge 3 commits into from
Closed

Timeseries #103

wants to merge 3 commits into from

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jul 22, 2018

@andig
Copy link
Contributor

andig commented Aug 13, 2018

It would be nice to make this consistent with e.g. the MySQL datasource:

this.formats = [{ text: 'Time series', value: 'time_series' }, { text: 'Table', value: 'table' }];

<select class="gf-form-input gf-size-auto" ng-model="ctrl.target.format" ng-options="f.value as f.text for f in ctrl.formats" ng-change="ctrl.refresh()"></select>

Renaming the value would obviously be a breaking change but does imho make sense for sake of readability.

@daniellee
Copy link
Contributor

Not sure I agree that this is worth a breaking change. I agree that timeserie is not correct English but it seems minor for something that would break everyone's dashboards. To accept a PR like this, it would have to migrate the panel data for any existing dashboards so that they are not broken.

@andig
Copy link
Contributor

andig commented Sep 30, 2018

This PR is also implemented in https://github.com/simPod/grafana-json-datasource and can be closed here.

@andig
Copy link
Contributor

andig commented Oct 5, 2018

Fixes #114

@Jonnymcc
Copy link

Jonnymcc commented Feb 8, 2019

Why are there changes in the Gruntfile and package.json? They seem unrelated to changing "timeserie" to "timeseries".

@simPod
Copy link
Contributor Author

simPod commented Feb 8, 2019

Yup but it was split to commits that have clear message so it's just 👌

However, we have maintained version at https://github.com/simpod/simple-json-datasource so closing this.

@simPod simPod closed this Feb 8, 2019
@simPod simPod deleted the timeseries branch February 8, 2019 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants