Implemented {Array, TypedArray}.prototype.{with, toReversed, toSorted} (#26, #27, #28, #29) #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana#26, grafana#27, grafana#28, grafana#29) `{Array, TypedArray}.prototype.toSorted` grafana#26 `{Array, TypedArray}.prototype.toReversed` grafana#27 `{Array, TypedArray}.prototype.with` grafana#28 `Array.prototype.toSpliced` grafana#29
|
Thank you for the PR @shiroyk 🙇 I will try to review it within the week |
This was
linked to
issues
Aug 6, 2024
Closed
mstoykov
reviewed
Aug 6, 2024
mstoykov
reviewed
Aug 6, 2024
mstoykov
requested changes
Aug 6, 2024
mstoykov
reviewed
Aug 6, 2024
mstoykov
requested changes
Aug 6, 2024
builtin_array.go
Outdated
Comment on lines
1360
to
1368
| if int64(cap(src.values)) >= newLength { | ||
| values = make([]Value, newLength) | ||
| copy(values, src.values[:actualStart]) | ||
| copy(values[actualStart+itemCount:], src.values[actualStart+actualSkipCount:]) | ||
| } else { | ||
| values = make([]Value, newLength) | ||
| copy(values, src.values[:actualStart]) | ||
| copy(values[actualStart+itemCount:], src.values[actualStart+actualSkipCount:]) | ||
| } |
There was a problem hiding this comment.
This code seems to be the same
There was a problem hiding this comment.
and arguablt is the same as the code I propose above, so it seems like we do not need all of those ifs.
mstoykov
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
LGTM!
Sorry for the slow reviews, but this kind of aligned with vacation time and us releasing a new k6 version.
We are currently trying to keep Sobek and goja as close as possible.
Do you want to make a PR to add this to goja as well or do you want me to do it for you?
|
Ah ... unfortunately me merging some updates from goja made conflicts wiht tc39_test.go - can you please fix them |
|
OK, I will add this PR to Goja. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{Array, TypedArray}.prototype.toSorted#26{Array, TypedArray}.prototype.toReversed#27{Array, TypedArray}.prototype.with#28Array.prototype.toSpliced#29