Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool/charts: versions overwriting each other #508

Closed
sh0rez opened this issue Feb 7, 2021 · 2 comments · Fixed by #710
Closed

tool/charts: versions overwriting each other #508

sh0rez opened this issue Feb 7, 2021 · 2 comments · Fixed by #710
Assignees

Comments

@sh0rez
Copy link
Member

sh0rez commented Feb 7, 2021

It is possible to require the same chart at different versions. However, the entry that comes last in the requires list effectively overwrites the others during helm pull.

Proposed solution would be a output or name key in Requirement to specify where the downloaded chart shall go. Also Tanka should catch this case during chart add and request you to specify the above new field.

@stale
Copy link

stale bot commented Mar 19, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 19, 2021
@bcbrockway
Copy link

I was just starting to look into how we might waterfall chart versions down dev, qa, prod, etc. without having to put the libs into separate git repos and vendoring the charts in there. I even tried adding a name key into the chartfile.yaml in the hope it might work before finding this ticket :)

TLDR; we'd be really interested in this!

@stale stale bot removed the stale label Apr 8, 2021
julienduchesne added a commit that referenced this issue Jun 1, 2022
Closes #508

Whenever two charts will end up in the same dir, tanka will exit before doing anything

Ex, these two versions would end up in the flagger dir:
```yaml
directory: charts
repositories:
- name: flagger
  url: https://flagger.app
requires:
- chart: flagger/flagger
  version: 1.16.1
- chart: flagger/flagger
  version: 1.17.0
version: 1
```

```console
$ tk tool charts vendor
Error: Output directory conflicts found:
 - output directory "flagger" is used twice, by charts "flagger/[email protected]" and "flagger/[email protected]"
```

It checks in both `add` and `vendor` commands to handle the case where someone writes their YAML manually
@julienduchesne julienduchesne self-assigned this Jun 1, 2022
julienduchesne added a commit that referenced this issue Jun 2, 2022
Closes #508

Whenever two charts will end up in the same dir, tanka will exit before doing anything

Ex, these two versions would end up in the flagger dir:
```yaml
directory: charts
repositories:
- name: flagger
  url: https://flagger.app
requires:
- chart: flagger/flagger
  version: 1.16.1
- chart: flagger/flagger
  version: 1.17.0
version: 1
```

```console
$ tk tool charts vendor
Error: Output directory conflicts found:
 - output directory "flagger" is used twice, by charts "flagger/[email protected]" and "flagger/[email protected]"
```

It checks in both `add` and `vendor` commands to handle the case where someone writes their YAML manually
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants