-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tool/charts: versions overwriting each other #508
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I was just starting to look into how we might waterfall chart versions down dev, qa, prod, etc. without having to put the libs into separate git repos and vendoring the charts in there. I even tried adding a TLDR; we'd be really interested in this! |
Closes #508 Whenever two charts will end up in the same dir, tanka will exit before doing anything Ex, these two versions would end up in the flagger dir: ```yaml directory: charts repositories: - name: flagger url: https://flagger.app requires: - chart: flagger/flagger version: 1.16.1 - chart: flagger/flagger version: 1.17.0 version: 1 ``` ```console $ tk tool charts vendor Error: Output directory conflicts found: - output directory "flagger" is used twice, by charts "flagger/[email protected]" and "flagger/[email protected]" ``` It checks in both `add` and `vendor` commands to handle the case where someone writes their YAML manually
Closes #508 Whenever two charts will end up in the same dir, tanka will exit before doing anything Ex, these two versions would end up in the flagger dir: ```yaml directory: charts repositories: - name: flagger url: https://flagger.app requires: - chart: flagger/flagger version: 1.16.1 - chart: flagger/flagger version: 1.17.0 version: 1 ``` ```console $ tk tool charts vendor Error: Output directory conflicts found: - output directory "flagger" is used twice, by charts "flagger/[email protected]" and "flagger/[email protected]" ``` It checks in both `add` and `vendor` commands to handle the case where someone writes their YAML manually
It is possible to
require
the same chart at different versions. However, the entry that comes last in therequires
list effectively overwrites the others duringhelm pull
.Proposed solution would be a
output
orname
key inRequirement
to specify where the downloaded chart shall go. Also Tanka should catch this case duringchart add
and request you to specify the above new field.The text was updated successfully, but these errors were encountered: