Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Servicegraph support for producer -> consumer spans #1604

Closed
Samuron opened this issue Jul 26, 2022 · 2 comments
Closed

Servicegraph support for producer -> consumer spans #1604

Samuron opened this issue Jul 26, 2022 · 2 comments

Comments

@Samuron
Copy link

Samuron commented Jul 26, 2022

Hello and thank you for your work here! We have started using Servicegraphs and this is a great feature, but I think it can be extended to support even more cases

Is your feature request related to a problem? Please describe.
Currently servicegraph only displays relationships between services based on spans with Client and Server kinds, it may make sense to extend the funcionality to treat Producer and Consumer in similar fashion to display relationships between peers that are communicationg using some kind of messaging

Describe the solution you'd like
Treat Producer as Client and Consumer as Server and draw relationship between them

Describe alternatives you've considered
Change telemetry to use Client and Server spans insteam of Producer, Consumer

@mapno
Copy link
Member

mapno commented Jul 26, 2022

Hi @Samuron, thanks for opening this issue. This is exactly what this PR is addressing 😄
#1576. It should be merged into Tempo shortly.

@annanay25
Copy link
Contributor

@Samuron I'll be closing this issue, feel free to reopen if you have any other questions. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants