metrics-generator: include messaging systems and databases in service graphs #1576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For testing: you can run this Tempo image in the intro-to-mlt demo https://github.com/grafana/intro-to-mlt/tree/kvrhdn/add-rabbitmq This will generate the following connections: |
mapno
reviewed
Jul 18, 2022
Comment on lines
+96
to
+103
| edge := newEdge(key, s.ttl) | ||
| update(edge) | ||
|
|
||
| if edge.isComplete() { | ||
| s.onComplete(edge) | ||
| return true, nil | ||
| } | ||
|
|
added 2 commits
July 20, 2022 16:16
|
I'll update the corresponding docs in a separate PR since I've a couple of changes pending and it's just going to clutter this PR. |
yvrhdn
requested review from
joe-elliott,
annanay25,
mdisibio and
zalegrala
as code owners
3 tasks
annanay25
approved these changes
Jul 27, 2022
Comment on lines
155
to
157
| case v1_trace.Span_SPAN_KIND_PRODUCER: | ||
| connectionType = store.MessagingSystem | ||
| fallthrough |
There was a problem hiding this comment.
I think we should add a comment here to emphasise why the producer case was placed before client and similarly for consumer <> server.
There was a problem hiding this comment.
Whoa, I've never seen fallthrough before. Neat.
zalegrala
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Include databases and requests across messaging systems in service graphs metrics. We rely on the OpenTelemetry semantic conventions to detect when a span is involved in one of these systems.
Links:
Messaging system: span kind will be
consumerandproducer. We addconnection_type="messaging_system"to the metrics.Database: span kind will be
clientbut there will be no matchingserverspan (the database is most likely not instrumented). We copy the values from the client side and use that to populate the server latency. Downside: you can't track the client and server-side latency of a request.We add
connection_type="database"to the metrics.Which issue(s) this PR fixes:
Fixes #1435
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]