-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search: drop use of TagCache, extract tags and tag values on-demand #1068
Conversation
I've been doing a test on my local set up fetching tag values for Avg latency sits around 200-400 ms. |
… of data from flatbuffers. Add new FindTag function
Drop tag cache 2
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
Still to address: when fetching tag values with very high cardinality (for instance Future improvements (not for this PR): we can add filter capabilities to the tag values endpoint, so if someone starts typing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the TagCache
struct?
Yep 👍, I've removed |
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
f76ea92
to
f7e95f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the limit check in. Good to merge.
Signed-off-by: Annanay <[email protected]>
22739f1
to
535263c
Compare
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
What this PR does:
Instead of storing tags and tag values in the TagCache we can extract them directly from live traces, WAL and local blocks when requested. This should lower the amount of work spent on updating the tagcache during ingest.
Since tag values are extracted on-demand, we are not limited anymore by the size of the tag cache. So this makes it possible to return thousands of values when needed.
Which issue(s) this PR fixes:
Fixes #Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]