updating go version from 1.18 to 1.19 #1665
Conversation
|
Had to add to a lot of places
|
ie-pham
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn and
zalegrala
as code owners
CHANGELOG.md
Outdated
| @@ -12,6 +11,7 @@ | |||
| * [ENHANCEMENT] Add PodDisruptionBudget to ingesters in jsonnet [#1691](https://github.com/grafana/tempo/pull/1691) (@joe-elliott) | |||
| * [ENHANCEMENT] Add span-level duration column [#1706](https://github.com/grafana/tempo/pull/1706) (@mdisibio) | |||
| * [BUGFIX] Honor caching and buffering settings when finding traces by id [#1697](https://github.com/grafana/tempo/pull/1697) (@joe-elliott) | |||
| * [CHANGE] Update Go to 1.19 [#1665](https://github.com/grafana/tempo/pull/1665) (@ie-pham) | |||
There was a problem hiding this comment.
nit: put with other entries of type "CHANGE"
cmd/tempo-cli/cmd-list-block.go
Outdated
| fmt.Println("End : ", unifiedMeta.EndTime) | ||
| fmt.Println("Duration : ", fmt.Sprint(unifiedMeta.EndTime.Sub(unifiedMeta.StartTime).Round(time.Second))) | ||
| fmt.Println("Age : ", fmt.Sprint(time.Since(unifiedMeta.EndTime).Round(time.Second))) | ||
| //nolint:all |
There was a problem hiding this comment.
what in the world did the linter not like about this?
There was a problem hiding this comment.
cmd/tempo-cli/cmd-list-block.go:74:46: unifiedMeta.Version undefined (type unifiedBlockMeta has no field or method Version) (typecheck)
fmt.Println("Version : ", unifiedMeta.Version)
| @@ -40,12 +40,12 @@ func displayCacheSummary(results []blockStats) { | |||
| bloomTable := make([][]int, 0) | |||
|
|
|||
| for _, r := range results { | |||
| row := r.CompactionLevel | |||
| row := r.CompactionLevel //nolint:all //embedded typecheck | |||
There was a problem hiding this comment.
same as the other one
cmd/tempo-cli/cmd-list-block.go:74:46: unifiedMeta.Version undefined (type unifiedBlockMeta has no field or method Version) (typecheck)
fmt.Println("Version : ", unifiedMeta.Version)
something is wrong with their embedded struct checking
There was a problem hiding this comment.
yeah, that just seems like a bug. i'd hate to chuck a bunch of nolints in our codebase b/c of a golangci-lint issue. can you track down any info on this issue?
There was a problem hiding this comment.
OH seems like they fixed it in their last release 8 days ago, will remove this
| @@ -18,7 +18,7 @@ func TestSubstringPredicate(t *testing.T) { | |||
| keptChunks: 1, | |||
| keptPages: 1, | |||
| keptValues: 2, | |||
| writeData: func(w *parquet.Writer) { | |||
| writeData: func(w *parquet.Writer) { //nolint:all | |||
There was a problem hiding this comment.
what does the linter not like about this?
There was a problem hiding this comment.
Oops. Forgot to put the reason there. But parquet.Writer is deprecated
tempodb/search/rescan_blocks.go
Outdated
| info, err := f.Info() | ||
|
|
||
| if err != nil { | ||
| level.Warn(log.Logger).Log("msg", "failed to file info", "err", err) |
There was a problem hiding this comment.
we're logging this as a warning but treating it as a fatal error by bailing out. if this error hits let's just return it instead of logging it and fail the whole rescan process.
return nil, fmt.Errorf("failed to file info %s, %w", f.NameORSomething, err)
What this PR does: Update go version from 1.18 to 1.19 and Golangci from v1.45.2 to v1.49.0
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]