Allow compactor disablement #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno and
yvrhdn
as code owners
mapno
reviewed
Nov 2, 2022
zalegrala
force-pushed
the
compactorDisable
branch
from
ad7b6c0 to
6fd0e32
Compare
mapno
approved these changes
Nov 2, 2022
Without this change, there isn't a good way to disable compaction when running in single binary or scalable single binary mode. Normally, when running in microservices mode, operators can simply scale down the compactors to 0 to effectively disable compaction, though this will have other consequences, since the compactors are doing a little more than compaction. Here we include a config option to disable compaction at the compactor level. This allows the compactor module to run, but disable compaction, allowing blocks to remain in the backend for debug or investigation purposes.
Signed-off-by: Zach Leslie <[email protected]>
Signed-off-by: Zach Leslie <[email protected]>
zalegrala
force-pushed
the
compactorDisable
branch
from
ccbfdbd to
127ce0b
Compare
zalegrala
commented
Nov 2, 2022
zalegrala
commented
Nov 2, 2022
Signed-off-by: Zach Leslie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, there isn't a good way to disable compaction when running in single binary or scalable single binary mode. Normally, when running in microservices mode, operators can simply scale down the compactors to 0 to effectively disable compaction, though this will have other consequences, since the compactors are doing a little more than compaction.
Here we include a config option to disable compaction at the compactor level. This allows the compactor module to run, but disable compaction, allowing blocks to remain in the backend for debug or investigation purposes.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]