Include distributor queue length in tempo-mixin #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
electron0zero,
ie-pham and
stoewer
as code owners
|
|
mapno
reviewed
Jul 7, 2023
| "uid": "cortex-ops-01" | ||
| }, | ||
| "editorMode": "code", | ||
| "expr": "sum(tempo_distributor_queue_length{cluster=~\"$cluster\", namespace=~\"$namespace\", job=~\".*/distributor\"}) by (pod)\n", |
There was a problem hiding this comment.
We should aggregate by name as well. There can be multiple queues in distributors.
There was a problem hiding this comment.
Looking again, I think you're right, but what about aggregate by name only? Then we get a sum of the length across all instances, which might clarify a little.
There was a problem hiding this comment.
I think it's about preference. Either sound good to me. I'll leave to you to decide.
zalegrala
force-pushed
the
distributorQueueLengthPanel
branch
from
5cc3463 to
3303831
Compare
mapno
approved these changes
Aug 30, 2023
yvrhdn
approved these changes
Aug 30, 2023
|
There are some errors in the mixin files, I think
This is a great feature to get, thank you! |
yvrhdn
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Update `make docs` procedure (#3026) * Update `make docs` procedure * Trigger CI --------- Co-authored-by: grafanabot <[email protected]> Co-authored-by: Jack Baldry <[email protected]> * Fix: pass-through to runtime overrides for FilterPolicies and TargetInfoExcludedDimensions (#3012) * fix: handle case when userconfigurableoverrides are enabled but empty * Add CHANGELOG.md * fix panic in test * fix GetTargetInfoExcludedDimens & GetFilterPolicies * update changelog * Include distributor queue length in tempo-mixin (#2623) * Include distributor queue length in tempo-mixin * Rebuild * Compile jsonnet * Compile jsonnet * Use C jsonnet to format mixin --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: grafanabot <[email protected]> Co-authored-by: Jack Baldry <[email protected]> Co-authored-by: Suraj Nath <[email protected]> Co-authored-by: Zach Leslie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Include the distributor queue length in the write path row of the tempo operational dashboard.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]