Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v2.2] Fix panic in the metrics-generator when using multiple tenants with default overrides #2806

Merged
merged 1 commit into from
Aug 18, 2023
Merged

[release-v2.2] Fix panic in the metrics-generator when using multiple tenants with default overrides #2806

merged 1 commit into from
Aug 18, 2023

Conversation

joe-elliott
Copy link
Member

Backport 9af6bb2 from #2786

What this PR does:
We have a concurrent read/write panic while reading from desiredProcessors, this is the only place we modify it really. Let's copy it before modifying it.

Which issue(s) this PR fixes:
Fixes #2785

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@joe-elliott
Fix panic in the metrics-generator when using multiple tenants with d…
6851027 
…efault overrides (#2786)

* Modify concurrency test to consider multitenant / concurrent updateProcessors calls

* Copy desiredProcessors map before modifying it

* Update CHANGELOG.md

(cherry picked from commit 9af6bb2)
@joe-elliott joe-elliott added type/bug Something isn't working backport labels Aug 18, 2023
@joe-elliott joe-elliott mentioned this pull request Aug 18, 2023
Closed
3 tasks
@joe-elliott joe-elliott merged commit 852e952 into release-v2.2 Aug 18, 2023
@joe-elliott joe-elliott deleted the backport-2786-to-release-v2.2 branch August 18, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annanay25 annanay25 Awaiting requested review from annanay25 annanay25 is a code owner

@mdisibio mdisibio Awaiting requested review from mdisibio mdisibio is a code owner

@mapno mapno Awaiting requested review from mapno mapno is a code owner

@yvrhdn yvrhdn Awaiting requested review from yvrhdn

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
backport type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joe-elliott