Tempo: add dedicated columns to block analyze #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
requested review from
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
stoewer
approved these changes
Oct 10, 2023
yvrhdn
pushed a commit
that referenced
this pull request
Oct 11, 2023
* disable parquet trace index by default (#2990) * Update parquet-go to include page header caching fix (#2981) * Tempo: add dedicated columns to block analyze (#2994) * adde dedicated columns to block analysize Signed-off-by: Joe Elliott <[email protected]> * load Signed-off-by: Joe Elliott <[email protected]> * lint Signed-off-by: Joe Elliott <[email protected]> --------- Signed-off-by: Joe Elliott <[email protected]> * Bump jaeger-query docker image to 1.50 (#2998) Signed-off-by: Pavol Loffay <[email protected]> * TraceQL: Experimental "not structural" operators (#2993) * first pass add Signed-off-by: Joe Elliott <[email protected]> * fix and tests Signed-off-by: Joe Elliott <[email protected]> * removed ancestor/descendant due to parsing issues Signed-off-by: Joe Elliott <[email protected]> * added tempodb lvl tests Signed-off-by: Joe Elliott <[email protected]> * parse tests Signed-off-by: Joe Elliott <[email protected]> * consolidated code Signed-off-by: Joe Elliott <[email protected]> * tests Signed-off-by: Joe Elliott <[email protected]> * docs Signed-off-by: Joe Elliott <[email protected]> * changelog Signed-off-by: Joe Elliott <[email protected]> * not ancestor/descendant Signed-off-by: Joe Elliott <[email protected]> * tempodb tests and docs Signed-off-by: Joe Elliott <[email protected]> * remove load Signed-off-by: Joe Elliott <[email protected]> * Apply suggestions from code review Co-authored-by: Kim Nylander <[email protected]> --------- Signed-off-by: Joe Elliott <[email protected]> Co-authored-by: Kim Nylander <[email protected]> * Update dskit (#3002) * Update dskit * fmt * Update prometheus to latest release v2.47.1 (c4d1a8b) (#3001) * Update prometheus to latest release v2.47.1 (c4d1a8b) I ran ``` go get github.com/prometheus/prometheus@c4d1a8b ``` And fixed any compilation issues * Checkin .test files from prometheus * go mod tidy * More fixes * Final set of fixes? 🤞 * Lint --------- Co-authored-by: Mario <[email protected]> --------- Signed-off-by: Joe Elliott <[email protected]> Signed-off-by: Pavol Loffay <[email protected]> Co-authored-by: Martin Disibio <[email protected]> Co-authored-by: Mario <[email protected]> Co-authored-by: Joe Elliott <[email protected]> Co-authored-by: Pavol Loffay <[email protected]> Co-authored-by: Kim Nylander <[email protected]>
sonisr
pushed a commit
to sonisr/tempo
that referenced
this pull request
Oct 11, 2023
* adde dedicated columns to block analysize Signed-off-by: Joe Elliott <[email protected]> * load Signed-off-by: Joe Elliott <[email protected]> * lint Signed-off-by: Joe Elliott <[email protected]> --------- Signed-off-by: Joe Elliott <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for dedicated columns to the
analyze block(s)cli command.Now when calculating total column size the commands will include dedicated columns if they exist.