Bugfix: Improved handling of complete blocks in localblocks processor after enabling flushing #3805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses an issue where old blocks were not being properly processed in the localblocks processor. The changes include updates to the deleteOldBlocks function to ensure that blocks that have exceeded the CompleteBlockTimeout are correctly identified and deleted. This prevents unnecessary accumulation of old blocks.
mapno
changed the title
mdisibio
reviewed
Jun 24, 2024
mapno
changed the title
mapno
requested review from
joe-elliott,
annanay25,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mapno
commented
Jun 24, 2024
mdisibio
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This fix addresses an issue where complete blocks were not being properly processed in the
localblocksprocessor. Before, complete blocks were kept for longer than necessary. This was a problem specially when enabling flushing to storage for the first time.The condition for deleting complete blocks has been changed to be based on block end time. If the block has been flushed and it's past it the cutoff time, it's deleted.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]