Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ReplicationFactor to uint8 in BlockMeta #3951

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Aug 9, 2024

What this PR does:

Here we reduce the size of the integer representing a block replication factor. Normal values are 1-3.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zalegrala zalegrala force-pushed the replicationFactorUint8 branch 3 times, most recently from 10991d8 to ae53f88 Compare August 9, 2024 15:45
@zalegrala zalegrala force-pushed the replicationFactorUint8 branch from ae53f88 to 1d066a0 Compare August 9, 2024 16:33
@zalegrala zalegrala marked this pull request as ready for review August 9, 2024 16:36
Copy link
Contributor

@ie-pham ie-pham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@zalegrala zalegrala merged commit 1a4c770 into grafana:main Aug 9, 2024
16 checks passed
@zalegrala zalegrala deleted the replicationFactorUint8 branch August 9, 2024 18:55
@joe-elliott joe-elliott mentioned this pull request Sep 3, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants