fix: correctly publish the hedgedmetrics counter with delta #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron0zero
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
ie-pham and
stoewer
as code owners
electron0zero
commented
Sep 12, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| ## main / unreleased | |||
|
|
|||
| * [BUGFIX] Correctly publish the hedgedmetrics counter with delta [#4078](https://github.com/grafana/tempo/pull/4078) (@electron0zero) | |||
| * [BUGFIX] Replace hedged requests roundtrips total with a counter. [#4063](https://github.com/grafana/tempo/pull/4063) (@galalen) | |||
There was a problem hiding this comment.
this entry was in # v2.6.0 section, should be in ## main / unreleased so fixed it.
joe-elliott
reviewed
Sep 13, 2024
electron0zero
force-pushed
the
fix_hedged_counter
branch
from
321d9a7 to
596ab7c
Compare
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
joe-elliott
force-pushed
the
fix_hedged_counter
branch
from
b5b56ab to
9022dcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
hedgedhttp.Statsis already a counter so we were incrementing the counter by the value of hedgedhttp.Stats counter.correctly calculate delta and increment the counter for hedgedhttp.Stats
Which issue(s) this PR fixes:
fixes #4060, we missed this detail of hedgedhttp.Stats in #4063
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]